search

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
777 stars 34 forks source link

Wrong logic in select suitable physical device #482

Closed BlauHimmel closed 1 year ago

BlauHimmel commented 1 year ago

https://github.com/inexorgame/vulkan-renderer/blob/3bb0e9d9ec9982c0d3d9052de7253c7b4c17d305/src/vulkan-renderer/settings_decision_maker.cpp#L445

When more than one suitable graphics card exist, it is the PhysicalDevices that are 'suitable' rather than all PhysicalDevices that are enumerated by vkEnumeratePhysicalDevices should be looped to calculate the score.

IAmNotHanni commented 1 year ago

Thank you, this falls into the other issue about replacing about removing this code part entirely: https://github.com/inexorgame/vulkan-renderer/issues/481

IceflowRE commented 1 year ago

Closed in favor of #481