inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
777 stars 34 forks source link

Use Vulkan Memory Allocator 3.0.1 and switch to Vulkan 1.3 for continuous integration #483

Closed IAmNotHanni closed 1 year ago

IAmNotHanni commented 1 year ago

Closes https://github.com/inexorgame/vulkan-renderer/issues/458 For more information read VMA's release note for 3.0.0 and release note for 3.0.1

Changes

Notes

Testing

It would be nice if @westernheld and @aschaeffer could compile and run the code to also verify nothing is broken :)

IAmNotHanni commented 1 year ago

Broken CI build

I guess something with the way we configure VMA is wrong. There were some changes: https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/releases/tag/v3.0.0

Solution

Ah it's much simpler, we need to switch to Vulkan 1.3 for this probably: https://github.com/inexorgame/vulkan-renderer/blob/main/.github/workflows/build.yml

env:
  inexor_build_type: "Release"
  inexor_vulkan_version: "1.2.189.0"
  inexor_vulkan_sdk: "$GITHUB_WORKSPACE/../vulkan_sdk/"
IAmNotHanni commented 1 year ago

Yes, that fixed it. Opinions?