[conan] Copy dll files into correct build folders on Windows

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development

https://inexor.org

MIT License

777 stars 34 forks source link

[conan] Copy dll files into correct build folders on Windows #502

Closed IAmNotHanni closed 1 year ago

IAmNotHanni commented 1 year ago

Closes #499 I also removed the unused instructions for mac os which is not supported

[x] Verify this does not break release workflow

IAmNotHanni commented 1 year ago

It does work, but we need to check if it affects devel release script :)

IceflowRE commented 1 year ago

~~RUNTIME_OUTPUT_DIRECTORY might be a look worth? Would have no hardcoded path. So conan copies to bin/ and we copy then in CMake to the correct one?~~

Just saw CMAKE_MSVCIDE_RUN_PATH, might be the thing we need.

IAmNotHanni commented 1 year ago

I don't think we can read CMake variables in conanfile.py? If not, we should just merge this fix as soon as possible because it affects debugging on Windows.

IceflowRE commented 1 year ago

Ok i digged a bit deeper into this.

The better solution would be to copy those files in our cmake setup after the conan setup, to the correct directories, and only if we have a multi config setup. I really want to avoid to copying all the .dll files multiples times if it is not required.

IAmNotHanni commented 1 year ago

Can you set that up pls?