search

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
795 stars 34 forks source link

Enable -Wall and -Wextra flags through CMake by default #505

Open IAmNotHanni opened 1 year ago

IAmNotHanni commented 1 year ago

Is your feature request related to a problem?

There are some warnings which we don't see because the -Wall and -Wextra flags are not enabed by default.

Description

Pass -Wall and -Wextra through CMake by default.

Alternatives

Do not enable those flags.

Affected Code

The entire project.

Operating System

All operating systems.

Additional Context

none

Denisthatorf commented 1 year ago

I want to help with this one. Can I try it ?

IAmNotHanni commented 1 year ago

Hey Bojack Thank you very much! Ofc you can :) @yeetari proposed to make it optional though by introducing a CMake profile or CMake option. Are you on our Discord?

best regards Johannes

Denisthatorf commented 1 year ago

Not yet

Denisthatorf commented 1 year ago

So with -Wall and -Wextra flags, I get a ton of extra messages. I think it is very smart to make it an INEXOR_BUILD_WITH_CHECK option with the default state OFF. Is it okay if I try to commit it?

IAmNotHanni commented 1 year ago

Yes, pls make a pull request :) I will work on fixing the warnings.