search

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
756 stars 33 forks source link

CMake option for adding -Wall and -Wextra flags #507

Closed Denisthatorf closed 1 year ago

Denisthatorf commented 1 year ago

Add option INEXOR_BUILD_WITH_CHECK, by default it is equal to OFF.

IAmNotHanni commented 1 year ago

Nice work! Pls name the commit with a tag at the beginning[cmake] Add option for adding -Wall and -Wextra flags

IAmNotHanni commented 1 year ago

@yeetari @IceflowRE Shouldn't it be named INEXOR_BUILD_WITH_CHECKS?

IAmNotHanni commented 1 year ago

I tested this with clang 14.0.6 and it works nicely. Thank you!

Denisthatorf commented 1 year ago

I changed what you requested. Can you check?

IceflowRE commented 1 year ago

Another question is: Should we enable this behaviour for our CI?

IAmNotHanni commented 1 year ago

That is a very good question I've been asking myself as well. The problem is that it makes no sense to keep it optional if we enforce it in CI