search

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
757 stars 33 forks source link

Fix gest and benchmark in Windows CI #529

Open IAmNotHanni opened 1 year ago

IAmNotHanni commented 1 year ago

Describe The Bug

For unknown reasons, Windows CI can't compile our tests and benchmarks. For now, only Linux CI does this.

Steps To Reproduce

Try to enable tests and benchmarks in the GitHub action for Windows CI again and it will fail

Expected Behavior

Since the tests and benchmarks can be compiled in Linux CI and here on my machine with Visual Studio 2022 locally, our solution can't be fully incorrect!

Affected Code

The continuous integration (GitHub actions) for Windows (both msvc and Clang)

Operating System

windows-latest in CI

Application Version

current master

Additional Context

none

Relevant Log Output

D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-src\googletest\src\gtest-all.cc(38,10): fatal  error : 'gtest/gtest.h' file not found [D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-build\googlemock\gmock.vcxproj]
  Building Custom Rule D:/a/vulkan-renderer/vulkan-renderer/build-debug/_deps/gtest-src/googlemock/CMakeLists.txt
D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-src\googletest\src\gtest-all.cc(38,10): fatal  error : 'gtest/gtest.h' file not found [D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-build\googlemock\gmock_main.vcxproj]
IAmNotHanni commented 1 year ago

We should also run the tests in the CI, but not the benchmarks. Keep in mind that our tests don't require a gpu to run!