inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
757 stars 33 forks source link

Remove incorrect manual use of VK_LAYER_RENDERDOC_Capture! #547

Open IAmNotHanni opened 1 year ago

IAmNotHanni commented 1 year ago

Is your feature request related to a problem?

I talked to the creator of RenderDoc (baldurk, Baldur Karlsson) on his Discord and asked if I should use VK_LAYER_RENDERDOC_Capture instance layer manually and he told me not to do this at all. This is used by RenderDoc if you launch the application through RenderDoc. You should never specify this manually. I'm not sure what I was thinking when I wrote this. That means the --renderdoc command line argument will be removed as well.

I would like to thank Baldur Karlsson once again for his overwhelming support every time I ask a question!

Description

This is just incorrect. I don't know what I was thinking. In my defence, it was for the good though. I wanted to improve debugging experience with it.

Alternatives

There is no point in keeping this at all. If you want to use RenderDoc for debugging, just launch the application through RenderDoc!

Affected Code

The instance wrapper and application.cpp

Operating System

All

Additional Context

None