inezkok / pe

0 stars 0 forks source link

Allows for duplicate employees with same details (except for id) #2

Open inezkok opened 1 year ago

inezkok commented 1 year ago

The product allows for employees with the same phone number and email and other fields to be added which is likely to be the same employee. It only checks for ID which might be a feature flaw.

This might be hard for employers to contact employees since they can have the same contact details.

image.png

Ways to reproduce:

  1. add i/A00001 n/John Doe p/97328601 e/johndoe@example.com d/Marketing r/Manager s/5000
  2. delete 2
  3. add i/A00002 n/John Doe p/97328601 e/johndoe@example.com d/Marketing r/Manager s/5000
soc-pe-bot commented 12 months ago

Team's Response

Thank you for your feedback. In our context, employees may share the same office telephone extension or a common email account (for example, admin@abc.com) so we chose not to have overzealous input verification as stated in the course website.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]