search

infamousjoeg / cyberark-aam-pkiaas

CyberArk AAM PKI-as-a-Service (CURRENTLY BETA)
Apache License 2.0
5 stars 0 forks source link

Add unit tests for pkg/pkiaas/api #76

Closed infamousjoeg closed 4 years ago

infamousjoeg commented 4 years ago

Is your feature request related to a problem? Please describe. The problem is that we have no unit testing for the API package of PKIaaS.

Describe the solution you'd like I'd love to have unit tests that are executable from go test.

Describe alternatives you've considered I've considered E2E testing using GitHub Actions, but I'd rather not rely on an external test suite and use the one provided by Go.

Additional context n/a

infamousjoeg commented 4 years ago

@rcobbins Are you able to give an example of a unit test using the dummy storage backend for @AndrewCopeland to use to complete the rest of the coverage?

AndrewCopeland commented 4 years ago

Resolved in this PR: https://github.com/infamousjoeg/cyberark-aam-pkiaas/pull/96