search

infamousjoeg / cybr-cli

A "Swiss Army Knife" command-line interface (CLI) for easy human and non-human interaction with @CyberArk suite of products.
Apache License 2.0
72 stars 16 forks source link

Adding 6 CEM sub-commands #105

Closed quincycheng closed 3 years ago

quincycheng commented 3 years ago

The following 6 CEM related commands are added:

First time writing in Golang. Please feel free to amend them. Thanks!

AndrewCopeland commented 3 years ago

The linter is failing and should be fixed with some quick code changes. I see duplicate code that might be able to be abstracted into a generic utils package. I do not mind using your personal repo for the cem-api-go library however it is missing tests, which is a concern of mine.

quincycheng commented 3 years ago

Thanks bros. Added some comments to variable names & functions accordingly. Let me try to add some tests for the cem-api-go this weekend

infamousjoeg commented 3 years ago

I have a pretty robust CEM environment. I can test this in the morning.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

infamousjoeg commented 3 years ago

@AndrewCopeland Ready for your review! I resolved the requested changes, so I cannot review.