search

infctr / eslint-plugin-typescript-sort-keys

A linter plugin to require sorting interface and string enum keys
ISC License
143 stars 25 forks source link

Consider contributing features up to typescript-eslint? #50

Closed JoshuaKGoldberg closed 4 months ago

JoshuaKGoldberg commented 2 years ago

Hi! I'm a maintainer on typescript-eslint and just stumbled onto this plugin from a feature request on the typescript-eslint member-ordering rule (https://github.com/typescript-eslint/typescript-eslint/issues/4859). It looks like much of this plugin's functionality is already in member-ordering.

Is there anything in particular you'd want to be added to member-ordering that doesn't exist in it already?

infctr commented 2 years ago

Hey @JoshuaKGoldberg Thanks for reaching out! There are many plugin users on npm, so I would expect all the of the options from interface and string-enum rules to be supported in member-ordering

infctr commented 2 years ago

I can see that requiredFirst: true is not supported in member-ordering, is it?

JoshuaKGoldberg commented 2 years ago

Ooh, it isn't, no. Now that I'm taking a deeper look I see the natural sorting option isn't either.

Are you up for filing an issue on typescript-eslint and/or sending a PR in? No worries if that's a sudden unexpected ask you don't have time for 😄, I can take on whatever you don't.

I'll also note our docs page isn't great right now and I plan on fixing it up soon: https://github.com/typescript-eslint/typescript-eslint/issues/4861

infctr commented 2 years ago

@JoshuaKGoldberg Go ahead :)

zachbryant commented 1 year ago

Just as a user looking between these two, the reason I'm choosing eslint-plugin-typescript-sort-keys is the auto-fixer

connorjs commented 1 year ago

Here’s the FR for auto fixer on official TS ESLint side: https://github.com/typescript-eslint/typescript-eslint/issues/2296

JoshuaKGoldberg commented 4 months ago

Closing out my old issues for repos I no longer have context on. If anybody has a need for what this issue was asking about, I'd encourage them/you to file a new issue. Cheers!