infctr / eslint-plugin-typescript-sort-keys

A linter plugin to require sorting interface and string enum keys
ISC License
144 stars 28 forks source link

Update package.json to support @typescript-eslint version 6 #64

Closed matzehecht closed 1 year ago

matzehecht commented 1 year ago

Bump peerDependency @typescript-eslint/parser to support version 6.0.0. Bump devDependency @typescript-eslint/parser and @typescript-eslint/eslint-plugin to 6.0.0

Pay attention, the minimum required node.js version is now set to 16, since @typescript-eslint itself only supports 16 and up (See v6.0.0 Release Notes).

infctr commented 1 year ago

@matzehecht Thank you for the contribution! Could you please have a look into failed tasks? 🙏

matzehecht commented 1 year ago

@infctr I am trying to figure out, why this happens. I am currently clueless. So help would be appreciated 😅 Even if I revert my changes and run yarn verify I get those errors. I will continue to search for a solution tomorrow.

matzehecht commented 1 year ago

I tried again today. The issue can only be resolved by updating typescript to a version higher than 4.7. But this leads to errors in other dependencies (e.g. @typescript-eslint/experimental-utils which is deprecated a long time and eslint-plugin-import). Updating those lead to some other breaking changes in the code itself (e.g. the "recommended" config of the rules or similar) and to issues with other dependencies as there are at least 22 dependencies outdated (and some of them are outdated a long time). As a one-time (or first-time) contributor I can not solve these issues because I don't have deep insights in this lib yet.

bmaupin commented 1 year ago

Is there a smaller change that could be made to unblock users of this library so they can upgrade to typescript-eslint v6 without breaking the tests?

For example, would changing this in package.json:

"@typescript-eslint/parser": "^1 || ^2 || ^3 || ^4 || ^5",

to this:

"@typescript-eslint/parser": "^1 || ^2 || ^3 || ^4 || ^5 || ^6",

work?

Then the TypeScript issues could be resolved at a later time in a separate PR.

stevensacks commented 1 year ago

What is the status of this? Can we get that change to add ^6?

infctr commented 1 year ago

Fixed in #67