infctr / eslint-plugin-typescript-sort-keys

A linter plugin to require sorting interface and string enum keys
ISC License
147 stars 28 forks source link

Upgrade peer dependencies #67

Closed thdk closed 1 year ago

thdk commented 1 year ago

This is an attempt to fix #65

infctr commented 1 year ago

@thdk thanks for the PR! Can you have a look at failed checks? Bumping prettier might seem to help

thdk commented 1 year ago

Bumped prettier. Removed old eslint rule from jest plugin. Fixed eslint config to only use typescript eslint plugins for typescript files because it will otherwise fail on linting javascript files such as .eslintrc.js which are not included in a tsconfig.json file.

Now some tests still fail on:

  ● Test suite failed to run

    Cannot find module '@typescript-eslint/parser' from 'tests/helpers/configs.ts'

    Require stack:
      tests/helpers/configs.ts
      tests/rules/string-enum.spec.ts

       5 |
       6 | export const typescript: Linter.Config = {
    >  7 |   parser: require.resolve('@typescript-eslint/parser'),
         |                   ^
       8 |   parserOptions: {
       9 |     sourceType: 'module',
      10 |     project: path.join(__dirname, './tsconfig.json'),

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (tests/helpers/configs.ts:7:19)
      at Object.<anonymous> (tests/rules/string-enum.spec.ts:5:1)
thdk commented 1 year ago

Upgraded jest to make tests work.

deniskabana commented 1 year ago

@infctr Can you please check this PR now? I ran into the same issue and was going to open the same PR :)

infctr commented 1 year ago

Looks good!

infctr commented 1 year ago

Published a new version

cpojer commented 1 year ago

Thanks so much for keeping this plugin fresh, I use it in all my projects and recommend it to everyone. It's part of @nkzw/eslint-config: https://github.com/cpojer/eslint-config.