Closed thdk closed 1 year ago
@thdk thanks for the PR! Can you have a look at failed checks? Bumping prettier might seem to help
Bumped prettier. Removed old eslint rule from jest plugin. Fixed eslint config to only use typescript eslint plugins for typescript files because it will otherwise fail on linting javascript files such as .eslintrc.js which are not included in a tsconfig.json file.
Now some tests still fail on:
● Test suite failed to run
Cannot find module '@typescript-eslint/parser' from 'tests/helpers/configs.ts'
Require stack:
tests/helpers/configs.ts
tests/rules/string-enum.spec.ts
5 |
6 | export const typescript: Linter.Config = {
> 7 | parser: require.resolve('@typescript-eslint/parser'),
| ^
8 | parserOptions: {
9 | sourceType: 'module',
10 | project: path.join(__dirname, './tsconfig.json'),
at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:322:11)
at Object.<anonymous> (tests/helpers/configs.ts:7:19)
at Object.<anonymous> (tests/rules/string-enum.spec.ts:5:1)
Upgraded jest to make tests work.
@infctr Can you please check this PR now? I ran into the same issue and was going to open the same PR :)
Looks good!
Published a new version
Thanks so much for keeping this plugin fresh, I use it in all my projects and recommend it to everyone. It's part of @nkzw/eslint-config
: https://github.com/cpojer/eslint-config.
This is an attempt to fix #65