infctr / eslint-plugin-typescript-sort-keys

A linter plugin to require sorting interface and string enum keys
ISC License
147 stars 28 forks source link

autofix #7

Closed bfmiv closed 4 years ago

bfmiv commented 5 years ago

Resolves #4

bfmiv commented 5 years ago

Here's the output of yarn test:

$ yarn test
yarn run v1.19.1
$ yarn lint
$ eslint lib/ tests/
$ mocha tests --recursive --reporter=dot

  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  251 passing (2s)

$ yarn docs:check
$ eslint-docs check
✔ docs/rules/interface.md is valid
✔ docs/rules/string-enum.md is valid
✔ The README is valid

✨  Done in 4.78s.
kg-currenxie commented 5 years ago

Awesome! Really want this merged :D @infctr 🙏

kg-currenxie commented 5 years ago

Found bugs actually; Inline types totally mess up a file

examples:

1. Screenshot 2019-11-07 at 10 39 02

2. Screenshot 2019-11-07 at 10 40 11

bfmiv commented 5 years ago

👍 nice, I will update and add a test. Thanks!

bfmiv commented 5 years ago

@infctr @kg-currenxie should be good now

$ yarn test
yarn run v1.19.1
$ yarn lint
$ eslint lib/ tests/
$ mocha tests --recursive --reporter=dot

  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  251 passing (2s)

$ yarn docs:check
$ eslint-docs check
✔ docs/rules/interface.md is valid
✔ docs/rules/string-enum.md is valid
✔ The README is valid

✨  Done in 3.94s.
kg-currenxie commented 5 years ago

new fix works well so far :) 👍

infctr commented 5 years ago

@bfmiv Thanks for your contribution, LGTM, I'll give it a try later this week!

bfmiv commented 4 years ago

@infctr bump - can we get this merged soon? FWIW I've been using this without problems across a range of projects for the last month or so.

infctr commented 4 years ago

@bfmiv Published

bfmiv commented 4 years ago

Thanks!