Open zachbryant opened 6 months ago
It's been a minute since I drafted this and now some packages have major bumps which change Node support. I will leave them as they are so this upgrade supports anyone who hasn't bumped to higher ESLint versions yet
Self review notes:
TSType
with Node
. It was necessary in-dev but also requires as unknown as Node[]
to work. Unknown casting has potential to be a source of bugs.
NodeOrToken
alias.extends: ["typescript-sort-keys/requiredFirst"]
works
Firstly, thanks for taking the time to look at this. Apologies the PR is so large. When I realized my attempt at patching the swap behavior for #26 wasn't going to work, this seemed like the next best approach, but I felt it had to come with proper testing given the breadth of work required. I tried to reuse as much as I could, but the amount of edge cases required adding/replacing a lot of logic. Definitely open to feedback on this approach if anything is simpler/more sound, even if its nontrivial.
Changes included
stylistic
instead ofwarn
string-enum
(#72)Package maintenance
fewer
strategyMisc changes
Known caveats & work left
I think this update should be released first as
4.0.0-alpha.1
in case anything goes terribly wrong.