Enable the Stop command to include a description of the measurement

infeeeee / kimai2-cmd

Command line client for Kimai2, the open source, self-hosted time tracker

MIT License

24 stars 6 forks source link

Enable the Stop command to include a description of the measurement #21

Closed JulesRenz closed 3 years ago

JulesRenz commented 3 years ago

Hi! Thanks for making kima2-cmd!

This PR adds a new feature to kimai2-cmd, that allows the addition of a "description" when a (specific) measurement is stopped.

This fits nicely in our workflow: When employees stops a measurement, they can enter a description of the activities they accomplished in the last minutes/hours, which then shows up in the Kimai UI.

I hope you like this PR and it finds its way into kimai2-cmd. Of course I am open to any suggestions you might have to make this new featuer even better!

Cheers Julian

infeeeee commented 3 years ago

Seems ok at first sight, thank you. I will test it later today, and if everything is ok, than I will pull it.

Please add JSdoc to all new functions, something like this:

/**
* This function does something
* 
* @param {string} varname this is a string
* @returns {object} The returned thing
*
*/

infeeeee commented 3 years ago

Thank you, sorry I could just check it now, everything is ok!

Thank you again for your contribution!!! 🎉

I will create new builds soon, I didn't set up Github actions yet...

JulesRenz commented 3 years ago

Hi @infeeeee , thanks a lot for merging this PR! Looking forward to the release. I have a couple of colleagues who are anticipating it :) Cheers Julian

infeeeee commented 3 years ago

Builds are up, 1.3.0 contains your code