search

infer-actively / pymdp

A Python implementation of active inference for Markov Decision Processes
MIT License
450 stars 89 forks source link

Incorrect error message when ensuring normalized A/B matrices #73

Closed conorheins closed 2 years ago

conorheins commented 2 years ago

In line 95 of agent.py

assert utils.is_normalized(self.B), "A matrix is not normalized (i.e. A.sum(axis = 0) must all equal 1.0"

I believe this is an error, as it should be the B matrix not the A matrix.

Originally posted by @mahault in https://github.com/infer-actively/pymdp/discussions/4#discussioncomment-2575940

helenegu commented 2 years ago

I think there's the same error in line 180 of agent.py, with reference to the D matrix

conorheins commented 2 years ago

I think there's the same error in line 180 of agent.py, with reference to the D matrix

Thanks for this, I'll make an issue that references this!