search

infernalstudios / Infernal-Expansion

Expanding the Nether beyond the Nether Update!
https://www.curseforge.com/minecraft/mc-mods/infernal-expansion
Apache License 2.0
59 stars 30 forks source link

Crash in glowstone canyon, FlyingMovementController cannot be cast to BlindsightEntity$MoveHelperController #329

Closed Jetpack-Cat closed 2 years ago

Jetpack-Cat commented 2 years ago

Describe the Bug

Running around the glowstone canyon, sudden crash

https://gist.github.com/Jetpack-Cat/1542ff778d8e2669263f0f465c5525b4

Reproduction Steps

run around nether in glowstone canyon

Expected Result

not to crash randomly

Screenshots and Videos

No response

Operating System

Windows 10

Mod Version

2.4.0

Minecraft Version

1.16.5

Forge Version

36.2.33

Other Mods

check crash log

Additional Context

none

Jetpack-Cat commented 2 years ago

I updated forge to 36.2.35 and it still happens

SwanX1 commented 2 years ago

Context I got from the crash report: Blindsight is riding a parrot, then the blindsight is trying to get the blindsight's movement controller helper, but gets a parrot movement controller helper which then is throwing a cast error.

Dariensg commented 2 years ago

Context helps a lot! I believe when an entity is riding another entity, the rider's AI is used for behavior, but the vehicle's navigation is used for the actual movement. Therefore, the Blindsight is trying to use its usual HopGoal for AI, but that requires a Blindsight MoveHelperController. Should be an easy fix, but would potentially remove all movement from Blindsights riding other entities. I'll leave this note here for when someone has a chance to fix it!

Jetpack-Cat commented 2 years ago

Ah, it's improved mobs. It makes mobs ride parrots to get to you if the entity has no way to reach you. eg if you're in a tree. I added the blindsight entity to the blacklist in my config..