infernalstudios / Nekos-Enchanted-Books

3 stars 8 forks source link

Format 1.20 port for main branch #47

Closed bm closed 11 months ago

bm commented 11 months ago

I am a little unfamiliar with the branch structure of this repo. Please take a look at my fork's 1.20 branch to see my actual implementation of the 1.20 port. Once the main repo creates a 1.20 branch, I can PR and merge.

These changes are tested and working on Minecraft 1.20.1/Forge 47.1.0. I added a 1.9 release with the jar built from my 1.20 branch.

SwanX1 commented 11 months ago

A few things to ask about for you. From where did you copy the files to the 1.20 directory from?

  1. build.gradle is completely wrong,
  2. settings.gradle doesn't have the 1.20 subproject (how did you even run the project???),
  3. 1.20/src/main/resources should not have any assets, they are taken from common/src/main/resources,
  4. pack.mcmeta's pack_format should be bumped,
  5. mods.toml should contain dependencies that are 0.0.1 and up, not 1.0.0, just like the other versions,
  6. runData config is incorrect, it crashed when I ran it.

All generated resources were incorrect, except for three, which means the generated directory was inconsistent, and somehow running your committed fixed that?

Also, the version for the mod shouldn't have been bumped, as we're only porting to 1.20 instead of making a new version of the mod.

SwanX1 commented 11 months ago

oops, pushed the wrong one, is merged with my changes. should work now

bm commented 11 months ago

Sorry I'm not very familiar with Gradle and subprojects. I just wanted to port this mod to 1.20 and made the PR in case you wanted it too. The Gradle stuff and structure may not be correct but the code changes work correctly in 1.20.