search

infernalstudios / Second-Chance-Forge

Port of the Second Chance Minecraft mod by zoeytheegoist
MIT License
1 stars 0 forks source link

[Feature request] add config option for % health instead of a static number #8

Closed EnderMelody closed 2 years ago

EnderMelody commented 2 years ago

could you add an option in the configs that allows us to us a % health needed for not being oneshot, and a config for % health remaining to go along with it?

Dariensg commented 2 years ago

Is there a particular reason you want that? I can't have two separate config options that affect the same thing, so I'd have to replace the existing one as a percentage option. The issue I see is that there are potential rounding issues with doing a percentage and it's possible you wouldn't be able to get the exact value you want. The plain health value based config lets you put in the exact value that you're trying to achieve.

EnderMelody commented 2 years ago

id like it to be a % as i would like it to only proc on 100% health, however having mods that increase your max health means i cannot simply put a single number in

Dariensg commented 2 years ago

I see... I guess I could put a config toggle to switch between using values and percents and then add a percent option. It might be a little while before I do this, but I'll get that in!

EnderMelody commented 2 years ago

much appreciated! if it makes it easier, i would be ok with an option that only checks for max health. I only requested a percent thing as i felt it would be more flexible for other peoples potential use cases.

Dariensg commented 2 years ago

Totally get it! I hadn't really thought of cases where in one world the player's health may change. Thank you for bringing it to my attention!

Dariensg commented 2 years ago

Added in abad1ebb1ef433a1950ebf4c3aee27d6a1f641bc