inferno-framework / bulk-data-test-kit

Inferno Test Kit for servers implementing the Bulk Data Access Implementation Guide
Apache License 2.0
0 stars 0 forks source link

FI-2249 Migrate Bulk Data 1 - Bulk Data Authorization and Group Compartment Export Tests #2

Closed emichaud998 closed 10 months ago

emichaud998 commented 11 months ago

Summary

Moved over Bulk Data Authorization tests and Group Compartment Export tests to this new Bulk Data Test Kit. Renamed everything in test kit from g10 to bulk_data and removed any unnecessary code that is used to build tests in the g10 test kit that are not being pulled into this new test kit. Also brought in the Inferno Reference Server preset to test with.

Testing Guidance

Run setup.sh and then run run.sh to build the test kit and run inferno. Ensure that test kit can be created and runs successfully and that the Bulk Data API test kit has all the test for Bulk Data Authorization tests and Group Compartment Export and that they run correctly.

yunwwang commented 11 months ago

Do we need anything in the "inferno" folder?

yunwwang commented 11 months ago

I would like the lib/bulk_data_test_kit folder to be reorganized as

lib
|_ bulk_data_test_kit
    |_ common /* any files are used by for both bulk data v1 and v2
    |_ v1.0.1
    |   |_ bulk_data_group_export.rb
    |   |_ multi_patient_api.rb
    |   |_ other v1.0.1 files
    |_ v2.0.0
        |_ bulk_data_group_export.rb
        |_ multi_patient_api.rb
        |_ other v2.0.0 files
emichaud998 commented 11 months ago

Do we need anything in the "inferno" folder?

It doesn't seem like it, as I tried running it with and without that folder and it didn't seem to break anything not having it. It looks like it mainly contains code for value sets and validators, which we are not including in this test kit. However, if you think I should look into this more or if you think that folder should be included, I can work trying to figure out if/how it should be incorporated in

yunwwang commented 11 months ago

Do we need anything in the "inferno" folder?

It doesn't seem like it, as I tried running it with and without that folder and it didn't seem to break anything not having it. It looks like it mainly contains code for value sets and validators, which we are not including in this test kit. However, if you think I should look into this more or if you think that folder should be included, I can work trying to figure out if/how it should be incorporated in

I think you can remove it. It could be generated from template.