Migrates from the original Inferno validator wrapper to the new HL7 validator wrapper. There should be no visible difference in the results, and there should be no special customization or configuration needed to get anything working. However the validator UI is no longer available by default.
Unlike the g10 cutover which used an env var to toggle between the 2, this one is a complete transition, so for example things like the env vars are replaced instead of adding new ones.
Note that I did leave the old validator commented out in the docker-compose file and nginx config so that if someone wants to use the validator UI with US core preloaded, they can uncomment those.
Bumped inferno-core to get the "don't run validator job in test" fix
Added hl7 validator to docker-compose and nginx config, commented out old validator items
Changed validator block in test suite template to fhir_resource_validator Renamed env vars
Added new message to ignore URL value '.*' does not resolve - this happens when the validator sees a URL and is configured not to fetch it, and was ignored natively in the Inferno validator but the HL7 validator doesn't expose the ability to ignore that so it has to be ignored in the test kit. (I also added FI-2697 to our backlog to make a "global" ignore)
There seems to be a bug in the error message limiting logic - error messages were being counted before they are actually filtered so if for example all errors were filtered and there were > 20 of them, you would still get the "Limited to 20 errors" message and fail the test. The fix is to only count non-ignored messages
Testing Guidance
Since inferno-core was bumped, you may need to run db migrations.
Summary
Migrates from the original Inferno validator wrapper to the new HL7 validator wrapper. There should be no visible difference in the results, and there should be no special customization or configuration needed to get anything working. However the validator UI is no longer available by default.
Unlike the g10 cutover which used an env var to toggle between the 2, this one is a complete transition, so for example things like the env vars are replaced instead of adding new ones.
Note that I did leave the old validator commented out in the docker-compose file and nginx config so that if someone wants to use the validator UI with US core preloaded, they can uncomment those.
This is based on the earlier g10 migration and US Core migration: https://github.com/onc-healthit/onc-certification-g10-test-kit/pull/488 https://github.com/inferno-framework/us-core-test-kit/pull/168
Code changes
validatorblock in test suite template tofhir_resource_validatorRenamed env varsURL value '.*' does not resolve- this happens when the validator sees a URL and is configured not to fetch it, and was ignored natively in the Inferno validator but the HL7 validator doesn't expose the ability to ignore that so it has to be ignored in the test kit. (I also added FI-2697 to our backlog to make a "global" ignore)Testing Guidance
Since inferno-core was bumped, you may need to run db migrations.