search

inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
24 stars 5 forks source link

Undefined method `warning' for Logger:0x0000561690c6b180 Did you mean warn? #228

Open kayadanae opened 2 years ago

kayadanae commented 2 years ago

ONC recently removed a test from Tab 6 of the g.10 test suite. Following this change, the input json file we had historically used contained inputs that Inferno no longer recognized. When trying to run the tests, our POST to https://inferno.healthit.gov/suites/api/test_runs was met with a 500 and the following response: {"errors":"undefined method 'warning' for #\u003cLogger:0x0000561690c6b180\u003e\nDid you mean? warn"}.

I believe this is coming from this line of code.

We updated our json to remove the no longer used inputs and are now seeing tests pass normally so this is non-blocking/non-urgent on our end, just wanted to report this little bug since I imagine others may run into it following the recent change as well.

Jammjammjamm commented 2 years ago

Thanks, we'll take care of that. Itshould be warn rather than warning.

arscan commented 2 years ago

We also need to document when inputs change in the release notes of a test kit (g10 in this case)... you shouldn't have to discover that through warnings in the log. FYI @Jack-Fraser16. Thanks @kayadanae!