search

inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

FI-2791: Revert resume test route refactor #497

Closed Jammjammjamm closed 5 months ago

Jammjammjamm commented 5 months ago

Summary

When there are multiple consecutive wait tests, there is a race condition which can put Inferno into a state where it fails to resume the test run. This branch reverts resume_test_route to no longer be based on suite endpoints which should prevent Inferno from getting into that bad state.

Testing Guidance

Locally in the PAS test kit, run bundle update inferno_core, which should bump core to 0.4.37. In the client suite, run the Demonstrate Workflow Support group, which should end up in a bad state:

Screenshot 2024-05-30 at 9 39 09 AM

This change was released as 0.4.37.dev so that we could use it in the connectathon. If you set core's version to 0.4.37.dev in the PAS test kit, or run the same tests on QA, they should no longer hang at this point.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (c3eb7c2) to head (8e89feb).

Files Patch % Lines
lib/inferno/dsl/suite_endpoint.rb 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #497 +/- ## ========================================== - Coverage 80.11% 79.71% -0.41% ========================================== Files 240 240 Lines 11909 11924 +15 Branches 1166 1167 +1 ========================================== - Hits 9541 9505 -36 - Misses 1705 1756 +51 Partials 663 663 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/497/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `92.27% <97.05%> (-1.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.