inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

FI-2787: AuthInfo input skeleton #503

Closed Jammjammjamm closed 3 months ago

Jammjammjamm commented 3 months ago

Summary

This branch provides an initial skeleton for a new type of input called auth_info. The goals for this input type are to consolidate all of the information needed to perform authorization, use that authorization to access resources, and refresh the authorization into a single location.

The intent is for the UI for this input type to be dynamic so that only the fields necessary for the particular scenario are displayed to the user. This will be accomplished through several means:

This branch does not implement the actual use of the auth_info input type, but exposes examples through the JSON API to support front end development for this feature.

Testing Guidance

There is a new auth info suite which containts tests with default input values for each of the modes and auth types. Since the UI for this input type is not yet implemented, the inputs will appear as text inputs. The tests will verify that the received inputs are what is expected, so as the UI is developed, they can be used to validate the UI behavior.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 61.93548% with 59 lines in your changes missing coverage. Please review.

Project coverage is 79.47%. Comparing base (732d0cd) to head (f76ccc0).

Files Patch % Lines
dev_suites/dev_auth_info/auth_info_suite.rb 74.07% 28 Missing :warning:
lib/inferno/dsl/auth_info.rb 45.83% 13 Missing :warning:
client/src/components/InputsModal/InputFields.tsx 10.00% 8 Missing and 1 partial :warning:
lib/inferno/repositories/session_data.rb 25.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #503 +/- ## ========================================== - Coverage 79.70% 79.47% -0.24% ========================================== Files 240 242 +2 Lines 11927 12080 +153 Branches 1169 1185 +16 ========================================== + Hits 9506 9600 +94 - Misses 1757 1815 +58 - Partials 664 665 +1 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/503/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `91.26% <65.27%> (-1.02%)` | :arrow_down: | | [frontend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `73.98% <18.18%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arscan commented 3 months ago

I'm ok with this approach for now.

Jammjammjamm commented 3 months ago

@arscan Could you approve the PR then?