Closed Jammjammjamm closed 3 months ago
Attention: Patch coverage is 61.93548%
with 59 lines
in your changes missing coverage. Please review.
Project coverage is 79.47%. Comparing base (
732d0cd
) to head (f76ccc0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm ok with this approach for now.
@arscan Could you approve the PR then?
Summary
This branch provides an initial skeleton for a new type of input called
auth_info
. The goals for this input type are to consolidate all of the information needed to perform authorization, use that authorization to access resources, and refresh the authorization into a single location.The intent is for the UI for this input type to be dynamic so that only the fields necessary for the particular scenario are displayed to the user. This will be accomplished through several means:
mode
option with the following possible values:auth
- this will present all of the input fields required in order to perform an initial authorizationaccess
- this will present the access token, as well as the fields required to refresh that access token, for tests which are accessing resources based on a prior authorization.use_discovery
checkbox in auth mode. When checked, the fields which can be found via a discovery endpoint will not be displayed to the user.auth_type
field allows the user (or the test writer) to select which auth workflow will be used, so that only the fields relevant to that particular workflow are displayed.This branch does not implement the actual use of the
auth_info
input type, but exposes examples through the JSON API to support front end development for this feature.Testing Guidance
There is a new auth info suite which containts tests with default input values for each of the modes and auth types. Since the UI for this input type is not yet implemented, the inputs will appear as text inputs. The tests will verify that the received inputs are what is expected, so as the UI is developed, they can be used to validate the UI behavior.