Closed jhlee-mitre closed 4 months ago
Attention: Patch coverage is 50.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 79.46%. Comparing base (
3a489d0
) to head (c8cb6f8
).
Files | Patch % | Lines |
---|---|---|
.../TestSuiteDetails/TestListItem/InputOutputList.tsx | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good, I would probably also double check the other instances of ReactMarkdown to see if they're also running into this issue and address accordingly but this is mergeable now.
LGTM
Thanks. A newbie question; I assigned three reviewers, should all of the three approve, or one approval out of three is good to merge?
Thanks. A newbie question; I assigned three reviewers, should all of the three approve, or one approval out of three is good to merge?
One is usually sufficient unless there is a reason to want approval from specific people!
Summary
Original issue: https://github.com/inferno-framework/bulk-data-test-kit/issues/24
Problem: contents in Inputs and Outputs are converted to markdown. Though it's useful for styles, can cause problems when strings like URLs are broken by that.
Fix: removed React Markdown in the HTML.
Testing Guidance
~~SAMPLE_TOKEN~~
)Consideration
react-markdown
is being used as below. Further investigation needs to figure out whether markdown is being used unnecessarily.