search

inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

FI-2857: Add auth input option #514

Closed AlyssaWang closed 3 months ago

AlyssaWang commented 4 months ago

Summary

Creates auth info inputs for both auth and access modes.

Testing Guidance

Confirm that inputs work with the AuthInfo test suite. Check new dropdown and single checkbox input options for behavior issues.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 76.50177% with 266 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (55dafb6) to head (3a55d12). Report is 1 commits behind head on main.

Files Patch % Lines
client/src/components/InputsModal/InputFields.tsx 40.20% 49 Missing and 9 partials :warning:
client/src/components/InputsModal/InputsModal.tsx 20.96% 45 Missing and 4 partials :warning:
client/src/components/InputsModal/AuthSettings.ts 90.00% 15 Missing and 20 partials :warning:
client/src/components/InputsModal/InputAccess.tsx 78.23% 13 Missing and 19 partials :warning:
client/src/components/InputsModal/InputAuth.tsx 77.44% 10 Missing and 20 partials :warning:
...src/components/InputsModal/InputSingleCheckbox.tsx 79.20% 15 Missing and 6 partials :warning:
...lient/src/components/InputsModal/InputCombobox.tsx 82.02% 8 Missing and 8 partials :warning:
...nt/src/components/InputsModal/AuthTypeSelector.tsx 88.23% 5 Missing and 3 partials :warning:
...c/components/InputsModal/InputOAuthCredentials.tsx 70.00% 2 Missing and 4 partials :warning:
...ent/src/components/InputsModal/InputRadioGroup.tsx 68.75% 4 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #514 +/- ## ========================================== + Coverage 79.69% 79.72% +0.02% ========================================== Files 243 249 +6 Lines 12178 13177 +999 Branches 1205 1290 +85 ========================================== + Hits 9705 10505 +800 - Misses 1808 1922 +114 - Partials 665 750 +85 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/514/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/514/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `91.66% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/514/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `74.64% <76.50%> (+0.65%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AlyssaWang commented 3 months ago

Ready for rereview. My main remaining question is concerning some values and how to normalize the capitalization:

get and post vs GET and POST s256 vs S256 es384 and rs384 vs ES384 and RS384

I've capitalized everything for now as I believe that's how they are in some of the non-dev tests but let me know if this should/will change.