inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

Fi-1930: Custom Result Rollup #516

Closed vanessuniq closed 4 weeks ago

vanessuniq commented 2 months ago

Summary

This PR enhances the result rollup feature to support custom result logic through a user-defined block. The changes include:

Testing Guidance

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.61017% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (9fab4c0) to head (f5e70ee). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...v_suites/dev_custom_results/custom_result_suite.rb 95.94% 3 Missing :warning:
lib/inferno/dsl/messages.rb 85.71% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #516 +/- ## ========================================== + Coverage 79.66% 79.83% +0.17% ========================================== Files 249 252 +3 Lines 13179 13305 +126 Branches 1283 1289 +6 ========================================== + Hits 10499 10622 +123 - Misses 1931 1934 +3 Partials 749 749 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/516/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/516/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `91.87% <96.61%> (+0.18%)` | :arrow_up: | | [frontend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/516/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `74.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vanessuniq commented 1 month ago

Test suite and group result now have messages and summary message. Only summary message for group is shown on the UI. messages are no shown. Screenshot 2024-08-09 at 9 42 07 AM