inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

FI-2887 Remove banner info from readme because that belongs in the docs site. #527

Closed arscan closed 2 months ago

arscan commented 2 months ago

I do not see a reason to have just this type of documentation in the inferno core readme. The appropriate place is the documentation site.

We've added that in https://github.com/inferno-framework/inferno-framework.github.io/pull/52

FYI @mrnosal

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.86%. Comparing base (48532ce) to head (498025d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #527 +/- ## ======================================= Coverage 79.86% 79.86% ======================================= Files 253 253 Lines 13351 13351 Branches 1290 1290 ======================================= Hits 10663 10663 Misses 1939 1939 Partials 749 749 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/527/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `91.84% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `74.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.