inferno-framework / inferno-core

Core library for the Inferno Framework
https://inferno-framework.github.io/
Apache License 2.0
26 stars 5 forks source link

FI-3172: Fix validator sessions #531

Closed Jammjammjamm closed 5 days ago

Jammjammjamm commented 6 days ago

Summary

This branch fixes the bug where validator session ids would get set to sessionId rather than a unique identifier.

Testing Guidance

Load up g10/us core and run multiple sessions with different us core versions at the same time. On main, this should cause the validator session error. That error should no longer be present on this branch.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.86%. Comparing base (8bce37b) to head (34e192d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ======================================= Coverage 79.86% 79.86% ======================================= Files 253 253 Lines 13351 13352 +1 Branches 1289 1290 +1 ======================================= + Hits 10663 10664 +1 Misses 1939 1939 Partials 749 749 ``` | [Flag](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `91.84% <100.00%> (+<0.01%)` | :arrow_up: | | [frontend](https://app.codecov.io/gh/inferno-framework/inferno-core/pull/531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework) | `74.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inferno-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.