Reviewed the code and did not find any critical problems. We may experience performance problems on very large ndjson files that could degrade server performance as described in #2, but I'm not sure that this needs to be addressed until it has been shown to be a realistic problem.
It is a straightforward set of tests that downloads ndjson files w/o auth, and validates their content. I noted that using meta.profile to choose which profile to validate against for Observations may not be the best approach as described in #3, but I know there are different views about meta.profile in the community.
It appears that care was taken to ensure that 'purple runtime errors' are avoided in general, and there is some nice flexibility in how to run the tests (eg. paste in manifest files or have it check a URL).
This doesn't do quite a bit of the IG that involves backend services and other parts of the import workflow, it appears, but that is ok.
I also verified that no profiles were set as 'global' profiles in the ImplementationGuide within the package.tgz, as that has side effects in shared hl7 validator instances.
Updates I made:
Updates gemspec to prepare for publishing to Ruby Gems
Changed to v0.9 to be consistent with our general convention right now
Removes ext/fhir_models
Add links to the UI for reporting bugs and to the published IG
Reviewed the code and did not find any critical problems. We may experience performance problems on very large ndjson files that could degrade server performance as described in #2, but I'm not sure that this needs to be addressed until it has been shown to be a realistic problem.
It is a straightforward set of tests that downloads ndjson files w/o auth, and validates their content. I noted that using meta.profile to choose which profile to validate against for Observations may not be the best approach as described in #3, but I know there are different views about meta.profile in the community.
It appears that care was taken to ensure that 'purple runtime errors' are avoided in general, and there is some nice flexibility in how to run the tests (eg. paste in manifest files or have it check a URL).
This doesn't do quite a bit of the IG that involves backend services and other parts of the import workflow, it appears, but that is ok.
I also verified that no profiles were set as 'global' profiles in the ImplementationGuide within the package.tgz, as that has side effects in shared hl7 validator instances.
Updates I made: