inferno-framework / uds-plus-test-kit

Apache License 2.0
2 stars 2 forks source link

Set Manifest read/validate input to optional for Resource-specific test group #4

Closed ljtucker closed 1 year ago

ljtucker commented 1 year ago

From email exchange w/ @arscan:

I was going over the UDS+ kit this morning and noticed a bug I overlooked when I passed the kit off to your team (I added a last-minute input option to one of the tests and forgot to set it to optional). I updated the bug and pushed the changes to my repo, but I'm not sure if your team forked their own version of the kit and won't see the change. Could your team integrate the fix into the kit on their end? Thank you, and sorry for the last-minute update.

I have checked out a branch for this repo and transferred the changes to it, but I do not have editor permissions for this repo, so I can't push the branch and make a pull request for it. Could I be given editor permissions, or could someone who already has permission move the changes from the original repo to this one? (The commit from the original repo is here, if you would like to look over the changes before proceeding).

ljtucker commented 1 year ago

The exact changes I made are:

arscan commented 1 year ago

Hi @ljtucker -- I pulled in your changes over into #5 just to get it done quick. Let me know if I missed anything there.

There are a number of options for how we can manage this in the future. We could add you as a maintainer, or if not just have you 'fork' this repo and issue pull requests using GitHub's tools.