search

inferno-framework / us-core-test-kit

Inferno Test Kit for evaluating API conformance to the US Core Implementation Guide
Apache License 2.0
7 stars 5 forks source link

FI-2481 Add PractitionerRole #156

Closed yunwwang closed 6 months ago

yunwwang commented 7 months ago

Summary

This fixed JIRA ticket FI-2481

Change Log

Testing Guidance

Start US Core Test Kit Verify US Core v5.0.1 test suite has optional PracitionerRole test group Verify US Core v6.1.0 test suite has optional PracitionerRole test group Verify US Core v7.0.0 ballot test suite has optional PracitionerRole test group Verify US Core v7.0.0 ballot test suite has Location test group Verify US Core v7.0.0 ballot test suite does NOT have VitalSign test group

yunwwang commented 6 months ago

This might require some major changes, and I don't know that we'd want to undertake this now, but I feel like the PractitionerRole tests could have practitioner as a first search, rather than being a read first group.

This is an interesting question. PractitionerRole.practitioner is a MustSupport and optional element. And PractitionerRole.practitioner SHALL support chained prameters. Hmm.

yunwwang commented 6 months ago

Also how we incoroprate this group to g10 is another big issue.

Jammjammjamm commented 6 months ago

Also how we incoroprate this group to g10 is another big issue.

Is this currently set up to save PractitionerRole references like other delayed resources? Do we need to update the reference server data to add support for this?

yunwwang commented 6 months ago

I have another ticket to update reference server data. PractitionerRole is treaty the same as other delayed reference, and the test group is currently marked as an optional group in US Core. If we want to include this test group in g10, then we have to remove the optional property. We need to figure out how to say that If there are delayed PractitionerRole reference, then run the PractitionerRole test group. If there is not delayed reference, then omit this test group. We need another property, other than optional. Maybe "semi-optional"?

Jammjammjamm commented 6 months ago

We need to figure out how to say that If there are delayed PractitionerRole reference, then run the PractitionerRole test group. If there is not delayed reference, then omit this test group. We need another property, other than optional. Maybe "semi-optional"?

I'll give that some thought. It's pretty annoying that this one needs to be treated slightly different than all the other groups.