search

inferno-pytorch / inferno

A utility library around PyTorch
Other
244 stars 41 forks source link

Cache reject #172

Closed constantinpape closed 4 years ago

constantinpape commented 5 years ago

@imagirom @Steffen-Wolf thanks working on this. Would be nice to merge it into master. Is there anything else we should add / fix before that?

constantinpape commented 5 years ago

Ok, unittests are not happy.... I might have some time to look into this next week.

imagirom commented 4 years ago

@constantinpape @Steffen-Wolf I changed the test to set random_jump_after_reject=False. The default behavior of ZipReject would be changed by this PR, but I think that makes sense as random_jump_after_reject=True is the better default behavior in my opinion. Should we finally merge this?

constantinpape commented 4 years ago

I think that makes sense as random_jump_after_reject=True is the better default behavior in my opinion.

I agree, this makes more sense.