search

inferno-pytorch / inferno

A utility library around PyTorch
Other
244 stars 41 forks source link

Update setup.py #183

Closed DerThorsten closed 5 years ago

DerThorsten commented 5 years ago

we cannot use statements as import inferno.__version__ in the setup.py since this statment is going to evaluate inferno.__init__.py This leads to many errors, in particular missing dependencies if one has not yet installed infernos dependencies yet 

    from inferno.version import __version__
  File "/home/thorsten/src/inferno/inferno/__init__.py", line 5, in <module>
    from . import extensions
  File "/home/thorsten/src/inferno/inferno/extensions/__init__.py", line 1, in <module>
    from . import containers
  File "/home/thorsten/src/inferno/inferno/extensions/containers/__init__.py", line 1, in <module>
    from .graph import *
  File "/home/thorsten/src/inferno/inferno/extensions/containers/graph.py", line 8, in <module>
    import networkx as nx
ModuleNotFoundError: No module named 'networkx'
constantinpape commented 5 years ago

Makes sense, this also explains the conda forge build issues.

constantinpape commented 5 years ago

@DerThorsten I will go ahead and merge right away, any objections?

DerThorsten commented 5 years ago

nope, can be merge

constantinpape commented 5 years ago

Great ! I will go ahead and update the conda-forge build.