Minor internal issues - Githubissues

ProditorMagnus commented 6 years ago

When creating script to transform EoMa to version suitable for ageless, I found that

[x] eomaprecision does not have eoma_ like other abilities
[x] Grand Summoner is TLU_Grand_Summoner instead of EoMa_Grand_Summoner
[x] Races tharis, cyclops, roc, salamander, summoner have no prefix
[x] MAGENTA_IS_THE_TEAM_COLOR is still used
[x] Some faction ids are like darkblood_rpg, others like destroyers. There is also alkamija_rpg, but summoners

[x] 20180525 21:12:27 error general: Mismatched parenthesis:

./units/Kharos/Child_of_Light.cfg:            halo="halo/silverwarrior-teleport[3~7].png~GS()~CS(30,30,30:100"
./units/Kharos/Mistress_of_Light.cfg:            halo="halo/silverwarrior-teleport[3~7].png~GS()~CS(30,30,30:100"

inferno8 commented 6 years ago

Fixed. Thank you for listing these. In case more are found in the near future, I'll re-open this.

ProditorMagnus commented 6 years ago

[x] EoMa_AncientCyclops description={NO_DESCR_AVAILABLE}+{SPECIAL_NOTES}+{SPECIAL_NOTESSLOW} - should not have
[x] Goblin Warrior has skirmisher special notes while not having skirmisher. Goblin Veteran should have the note instead.
[x] Goblin Hunter has positive traits, while its level up has negative traits
[x] Level 1 Camel Rider may not be strong, while level 2 and 3 can
[x] Dark Commander can be fearless, but not Dark Warrior
[x] poisonous aura description says loose instead of lose
[x] EoMa_Dreadnaught has defense_weight=0 without any description. I suggest [disable] instead https://github.com/ProditorMagnus/Ageless-for-1-14/blob/346004f0ffddc85aaf907676eeee63c564628e3b/data/general_data/weapon_specials/attack_only.cfg
[x] summon undead description has sounds not summons
[x] heal undead5 and 8 would look better with space
[x] Some unit_types have multiple tags where only one is expected, https://github.com/ProditorMagnus/Ageless-for-1-11/issues/25#issuecomment-392289784 (those that start with AEmag)
[x] 20180527 16:21:54<+discordbot1> Hello, I'm playing Era of Magic with my friend but whenever he upgrades a dwarven drone unit we both get an error saying something like "invalid WML file, able_to_advance[] missing". Does anyone know how to fix this? - For [else] path a is not defined https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/utils/drone-upgrades.cfg#L550

I noticed that Toad Shaman line has strange resists

inferno8 commented 6 years ago

I noticed that Toad Shaman line has strange resists

Could you describe the problem more? Is it about the increase in pierce resistance or something else?

ProditorMagnus commented 6 years ago

Didnt look much which resistance changed, it just has so much higher total resists than other choices. Battle Archer Mage resistance sum Level 1:+10 Level 2:+40 +20 +70 Level 3:+60 +30 +120

inferno8 commented 6 years ago

All fixed. Thank you once again 😉

ProditorMagnus commented 6 years ago

[x] runeaura uses "portraits/ancient_dwarves/transparent/runemaster.png" which seems to have been removed from EoMa, ageless still has it

inferno8 commented 6 years ago

There will be a new portrait in the next version.

ProditorMagnus commented 6 years ago

https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/EoMa_eras.cfg#L14-L15 that newline looks strange in game.

It is actually https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/EoMa_eras.cfg#L38-L39 newline now.

[x] sound is not allowed in [if] https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/utils/awake.cfg#L127
[x] awaken does not work sometimes, both attack events write same variable, so if two 1 hp inspireds next to another inspired of their side fight, and attacker kills defender, defender will be resurrected. It can also happen that two 1hp units fight, both survive, they go heal, and then one gets killed next to inspired. Awakememo still contains one of those units, so awaken does not works when it should.
[x] https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/utils/banish.cfg#L246 seems unused
[ ] Beam might be affected by the facing oos, I am not planning to check it currently
[x] https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/utils/chancetohit.cfg#L15 maybe mention swarm too, but that is quite internal behavior that might not remain. Might be more reliable to implement it as [disable], then berserker handling would not be needed either.

ProditorMagnus commented 6 years ago

Rewrote awake to work more reliably.

ProditorMagnus commented 6 years ago

[x] Why is hide_help included from plague file? https://github.com/ProditorMagnus/Ageless-for-1-14/issues/5

ProditorMagnus commented 6 years ago

[x] Resources addon should not depend on main addon - it breaks update all when there is cycle. It is also not really ideal for ageless.

ProditorMagnus commented 6 years ago

[x] 20180622 19:54:03 warning gui/layout: pango_text::validate_markup text (Era: Era of Magic (Masters & Slaves)) has unescaped ampersands '&', escaped them.

It wants &

ProditorMagnus commented 6 years ago

[x] 20180703 13:09:17 error general: Square bracket lengths do not match up: units/skykingdom-magi/enlightened-mastermage-attack-magic[2-1,3-1,4-1,1-3].png:[60*4,280] https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/units/Sky_Kingdom/Mastermage.cfg#L98

ProditorMagnus commented 6 years ago

I prepared another set of changes that I keep different from EoMa https://github.com/ProditorMagnus/Ageless-for-1-14/commit/3cbd94f5cc2900d650401c8a4a1fa5f31bbbf9a7.

Out of those I suggest for EoMa:

[x] Disable bone collector for leaders, or in rpg. I disabled it for leaders.
[x] Disable sculpt on leaders, or in rpg. I disabled it in rpg.
[x] Disable awe, summon, summon_undead_event in rpg. Maybe not awe, but currently it can reach too high values to allow in ageless rpg.

I implemented rpg check as https://github.com/ProditorMagnus/Ageless-for-1-14/blob/master/lua/preload.lua#L10-L22

I feel jinn is too powerful with its 5-4 and regen. I still remember when it was 4-3 and no regen and still people used it.

ProditorMagnus commented 6 years ago

[x] Using movecost 100 results in warnings. Affected files modified: Runemasters/RuneMaster2.cfg ~~Havent set up clone yet.~~ Got clone now.

ProditorMagnus commented 6 years ago

I think this is from EoMa,

Destroyers/Infernal_Vortex.cfg:            halo="halo/air-lightning/00[010~06].png"
Destroyers/Dark_Portal.cfg:            image="halo/air-lightning/00[010~06].png"

[x] 20180707 18:21:58 error general: Square bracket padding sizes not matching: 010 and 06.

ProditorMagnus commented 6 years ago

[x] # wmlindent: start ignoring and # wmlindent: stop ignoring should handle it

ravana@ravana-think ~/wesnoth/userdata_1_14/data/add-ons/Era_of_Magic $ wmlindent -d .
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 673: close tag [/variation] with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 1087: close tag )} with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 1104: close tag [/variation] with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 2115: close tag [/variation] with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 2622: close tag [/variation] with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 2709: close tag [/variation] with indent already zero.
wmlindent: "./units/Destroyers/corpse_walking.cfg", line 2882: close tag [/unit_type] with indent already zero.
wmlindent: "./utils/doubleattack.cfg", line 29: close tag [/attack] with indent already zero.
wmlindent: "./utils/doubleattack.cfg", line 116: close tag [/attack] with indent already zero.
wmlindent: "./utils/sculpt.cfg", line 12: close tag [/attack] with indent already zero.
wmlindent: "./utils/abilities.cfg", line 1023: close tag [/specials] with indent already zero.

ProditorMagnus commented 6 years ago

[x] <[21:17] EIder> goblin kamikaze zombie doesnt die when using kamikaze attack I verified it happens in EoMa, but did not find cause for this. I see that event is not added to inspect events list.
[x] same happens for cyclops, wyvern and maybe more - seems that events under variation are not recognized. If I #ifdef code adding eoma_summoned_zombie, event gets registered.

ProditorMagnus commented 6 years ago

[x] damage aura should not affect invulnerable or petrified units - same for all area damages

fixed for petrified

ProditorMagnus commented 6 years ago

I did some more testing with kamikaze case. Observations:

Initial case has eoma_summoned_zombie working and variation event not working
When removing eoma_summoned_zombie [modifications], then variation event works
When making https://github.com/inferno8/wesnoth-Era_of_Magic/blob/master/units/Destroyers/Cyclops_Necromancer.cfg#L407 to {RANDOM 14..14}, then eoma_summoned_zombie works and variation event works

That last one seems completely unrelated, so I am not comfortable creating issue for that yet.

inferno8 commented 6 years ago

From https://forums.wesnoth.org/viewtopic.php?f=8&t=31799&start=900#p631133

[x] Chaos Hydra: Compared to (Great) Hydra, the order of the attack specials of 'bite' has changed. Normal: swarm, triple strike, drain. Chaos Hdyra: swarm, drain, triple strike.
[x] Dimensional gates can earn XP when they are being hit by a triple strike (as a secondary target). This is also true for cleave attacks. While the xp get's wiped by the start of someone elses turn, you theoretically can level up a Dimensional Gate without it having to kill something.
[x] Triple strike can drain from secondary targets, even if that target is magical or whatever says that the can't be drained.
[x] And draining a secondary target removes all applied debuffs (to the hdyra). Your hydra is slowed or poisoned? No problem! Just let it drain a secondary target. (This really sucks is 'Defense of Saffaros' when you use a row of water elementals with melee slow as defense.)
[x] After the fight is over, the secondary targets hp is set to 'hp before fight - dmg done by first secondary hit'. So every hit after the first one doesn't count, unless you kill the secondary target.

inferno8 commented 6 years ago

From https://forums.wesnoth.org/viewtopic.php?f=19&t=20039&start=1590#p632389

Barbarians

[x] Growing Fury: It stacks with every landed strike, even in berserk rounds... making them complete destroyers of any berserk unit that is not swift foot. A possible suggestion to balance this special is giving a cap of strikes that may get damage boost (recommended is that after 3rd strike the unit gains no extra damage at following strikes). Imagine the case of a cyclops breaker hitting all 4 of 4 strikes, 4th strike would be 23 damage that one strike (not completely confirmed) but there is the chance that 2nd strike starts with already boosted damage instead of base damage, this needs revision.
[x] Furious Death / Hard-landing: There is an issue with those 2 specials that if any unit with this special dies and due the explosion it kills another unit that has this same special or the other, triggers a bug in which for a very long period of time, both dying units will deal crazy amount of damage and literally killing ALL units between those 2, apart of a large error in your chat. ForestDragon's comment: this bug is due to fire_event=yes being present in both events in [harm_unit], and thus whenever a unit dies, it triggers all adjacent units' death events upon kill, and they activate theirs, which in turn activates the original unit's ability, etc.). This can probably be fixed by having furious death not kill units with the furious death ability, or adding a variable filter in the last breath that disallows the usage of the ability twice in one event (with the variable being set to yes after [harm_unit], and cleared at the end of the event). Both specials need to be fixed to not trigger more than once if those units are slain by another unit with one of those specials and triggering those specials in an endless cycle of furious death/hard landing events.
[x] Cyclops Breaker Would recommend to rework the main attack that has no double-attack Fist damage adjusted from 7-4 (growing fury 4) to 5-5 (growing fury 3)
1st strike will be 5 damage
2nd strike will be 8 damage
3rd, 4th and 5 strike will be 11 damage each one.

For a total of:

New version	Old version
5 damage if hitting once.	7 damage if hitting once
13 damage if hitting twice.	18 (7 + 11) damage if hitting twice
24 damage if hitting 3 times	33 (7 + 11 + 15) damage if hitting 3 times
35 damage if hitting 4 times	52 (7 + 11 + 15 + 19) if hitting 4 times
46 damage if hitting 5 times	48 (7 + 11 + 15 + 15) if hitting 4 times, old 7-4 (rage 4 with 3 strikes cap)

This will favor this unit at rarely missing all hits to an unit (specially vs swift foot), for strong trait add +1 damage per strike that did hit.

[x] Blood Warrior The unit is more likely to be fine, but at being considered a safe berserker (unit that has an optional melee without berserk) is very questionable if it's balanced to be a leader option. In default dwarvish berserker was disabled as leader. May be a better choice not allowing this unit as a leader option.
Dark Blood Aliance
[x] Lv2 toads as leader choice This is the exact same case than Dwarvish Tanks, those units are too tanky and unlike dwarvish tanks that may be repaired from standing a unit next to them toads have +8 natural regen no matter the tile they're in. May be a better choice not allowing toad's advancement be leader options.
Kharos
[x] Child of Light - Almost everybody picks this unit as leader mostly because there are likely NO REASONS to pick bishop as leader because this unit has much better mobility, both have leadership and the difference of damage is not that significant. Can consider some moderate reworks at child of light.
- Movement from 7 to 6 (no unit in default era that is in leaders option has 7 movement).
- Will no longer have +leadership. Will have a inspires 1.
- XP from 160 to 143 (exact 100 XP at 70% xp modifier)

This unit is still a viable option because it has much better mobility, flies, 50% def at flat, magical on mele and +1 movement than bishop. Doesn't need a very strong leadership aura to work fine. Apart that in survivals happens that a player doesn't even recruit adepts of light but recruits and level up sisters of light.

[x] Mistress of Light Giving leadership and illuminates to the same unit gives an absurd boost to Kharos units. Going to degrade leadership and decreasing its movement points by one.
- Movement from 8 to 7
- Will no longer have +leadership. Will have inspires 2.
- Inspires 2 will be +45% damage for lv0, +25% damage for lv1, +6% damage for lv2

This will difficult the viality of a build with only child of light, Lv2 shielders and nothing else...

[x] Inspired - I'm not really sure how effective might be the awaken special in a 1vs1 game. Remembering that saved units may give XP twice if slain twice lol. Because of not having a real idea how strong and worth can be this special in a player vs player match I would suggest not touching this at the moment and looking at it more carefully (testing with AI might not work). ForestDragon commentary: the exp bug can be fixed by removing exp from attacker proportionately to the unit level, like with the Dharma/Horashti last breath events in TLU.
Runemasters
[x] Dwarvish Tank - It's not the same having as leader a 67 hp unit than a 40 hp unit, specially in 1vs1 games. Dwarvish tank is not a frail unit nor a weak unit nor a frail unit nor a slow unit. This unit has acceptable mele and good ranged damages. As far I can see only barbarians have no problems at killing this unit as leader option.
- May be a better choice not allowing this unit as a leader.
  Sky Kingdom
[x] Pyromancer / Master of fire - This unit has lower percent of usage than inteded,f as far almost nobody level up an elementalist to a pyromancer because a war mage has almost the same ranged damage and sorcerer has more raw ranged damage. Maybe can be tried a movement buff.
- Movement from 5 to 6 Master of fire and Master of air both doesn't regenerates unlike Master of water, which is one of the reasons why most people level up to hydromancer. Extra movement in master of fire will help him to perform more at par to master of water. Master of Fire
- Health from 55 to 58
- Movement from 5 to 6
[x] Hydromancer / Master of Water - Is the exact opposite case of Pyromancer, most elementalist are leveled up to hydromancers, while Pyromancers and Aeromancers are less picked. The movement that we gift to Pyromancer are now substracted from Hydromancers.
- Movement from 6 to 5 Master of Water
- Health from 58 to 55
- Movement from 6 to 5
[x] Black Mage - I do not see any problem if the slowing attack from the lv2 is magical instead of +skilled considering that it's the exact same damage than in lv1 but with one extra strike.
- entrapment spell might be +magical instead of +skilled.
  Summoners
[x] Efreeti - While comparing efreeti with Pyromancers it's obvious that the player that starts with pyromancer as leader has starting disadvantage just because of the unit they start with. To decrease this, sadly, efreeti will move slower like jinns.
- Movement from 6 to 5 ForestDragon's comment: this nerf can be done with a unit placed event in multiplayer, instead of nerfing the unit entirely. Still, Lv3 advancement will be 7 which means lv3 movement is not modificated.
[x] Great Jinni / Efreeti / Great Efreeti / Wonderfull jinni This change will only affect if those units are leaders. Those 4 units (in EoMa and heroic EoMa) will start with +weak trait if its your starting leader unit. This will only cost them 1 melee damage per strike and 1 health point.
[x] Rhami’datu / Rhami’kai / Ho’rhami / Dharma’rhami - Exact same case than in Jinns and Efreetis, weak trait to decrease the advantage from starting with this unit. Those 4 units will start with +weak trait if it's your starting leader unit. A good reason of those weak traits is that usually units that have regen have low damage or low health as handicap, but this is not the case of all those magicals that have regenerates.
Tharis
[x] Dark Assassin - Would recommend that this unit won't be in leaders list because of the hit and run which if used smartly can make an huge difference from other choices, apart of 7 movement unit. May be a better choice not allowing this unit as a leader option.
[x] Dark Slayer - I don't see any problem at giving it few extra health considering that it gains only 4 hp when leveled and it doesn't has massive damage at all.
- Health from 40 to 42 This one fighter feels weak compared to others from other factions, but at having skirmisher allows other units to use backstab more effectively which in part it's one of the roles of this one unit. Still, its lv3 is fine.

ProditorMagnus commented 5 years ago

Solved kamikaze zombie issue by creating dummy unit at prestart that always loads all events that might be needed.

ProditorMagnus commented 3 years ago

Is it time to close this task? All points look solved.

inferno8 / wesnoth-Era_of_Magic

Minor internal issues #16

Barbarians

Dark Blood Aliance

Kharos

Runemasters

Sky Kingdom

Summoners

Tharis