search

inferno8 / wesnoth-Era_of_Magic

add-on for Battle for Wesnoth
GNU General Public License v2.0
10 stars 4 forks source link

Summon refactor Mk. 2 #47

Closed Slayer95 closed 1 year ago

Slayer95 commented 1 year ago

Partial revert of 6acaa82. The handler causes issues because it's actually added by the engine after scenario-specific handlers.

Slayer95 commented 1 year ago

PTAL. This commit:

inferno8 commented 1 year ago

Very impressive. Is the PR ready for merging in its current state?

Slayer95 commented 1 year ago

Waiting for confirmation from @ProditorMagnus re: overlays.

Slayer95 commented 1 year ago

Alright. Applied some macro tips from another review and rebased.

Ready :]

Slayer95 commented 1 year ago

By the way, the current location rules re: castles seem a bit too arbitrary to me. 1 Summoner inside tries to summon outside: Forbidden (OK, critical for balance purposes to avoid stalling)

  1. Summoner outside tries to summon inside: Allowed (Why?)
  2. Summoner inside tries to summon inside: Forbidden (Why?)

IMO, it would be better that summoning be allowed only if both the summoner and summoned would be in the same side of the castle (inside vs outside), i.e. 1 Forbidden, 2 Forbidden, 3 Allowed.

Flavor-sense, it makes sense wholly. Just think of the castle walls as barriers.

Balance-wise, there are several actions/strategies affected.

  1. Defense: Sieged summoners are allowed to plug holes in their defenses, but are not allowed to attack the invaders that turn. In a standard castle layout, they would remain exposed to attacks (neither the new zone of control shield the summoner.)
  2. Offense: Summoners are no longed allowed to sneak magical beings into an enemy castle (very cheesy and disrupting strat.). However, they get the chance to summon reinforcements after the castle is broke through, at the cost of their attack; but would that be a wise decision? Player would need to consider whether the opportunity cost is worth it (after breaking through, a low HP summoner might be better served by retreating before summoning reinforcements.)
inferno8 commented 1 year ago

Interesting. It would change some strategies of Summoners but in a good way, I think. You analysis convinces me. Yeah, we can try these new summoning mechanics. I approve this proposal.

Slayer95 commented 1 year ago

Great! Then the EXCEPT_FROM parameter is no longer needed.