useState hook

[simonjoom]

Does inferno compatible with the new react hook useState?

[Havunen]

No, not yet at least

[hronro]

@Havunen Is there any plans to implement hooks in the future?

[simonjoom]

preact just implemented a hook compat version

https://github.com/developit/preact/tree/master/hooks

i looked on code, maybe can somebody inspired to add this support to inferno?

I would like to use amazing react-spring who use hook system =)

[stylemistake]

It seems that hooks aren't that hard to implement. All Inferno hook points are clearly defined, we just need to expose them on an options object, and copy paste, wire up the Preact's file.

[BaibhaVatsa]

Hi! I was interested in working on this issue if this is still open and good to go for

[stylemistake]

@BaibhaVatsa Yes, I'd really like to see this implemented.

[BaibhaVatsa]

Since I am new to this project, would you like to give me any pointers regarding the implementation apart from the link to preact implementation?

[stylemistake]

This is a very basic, bare bones setup for hooks (i was coding it inside tgstation repo, which is less than ideal, but this diff will give you the basic idea) : https://github.com/stylemistake/tgstation/commit/d1b13851c3131ea5c35db79e93d84b7b8ac6f647

I think these are all the hook points necessary to implement the top level React Hooks API in Inferno. You can use the options object to expose various inferno internals.

Then we have this (preact hooks), what i think is the cleanest implementation of react hooks out there: https://github.com/preactjs/preact/blob/master/hooks/src/index.js

The main stopper is that you can't use these hooks as is, because:

• options object is different in preact, they expose their internals differently, and renderer as well works a bit differently;
• their virtual dom objects are also different, and they put hook metadata into them (__hooks property), to keep track of the lifecycle,

They also have this stinky bit, this is where I personally got stuck: https://github.com/preactjs/preact/blob/master/hooks/src/index.js#L47-L61

They have a commit queue and a _renderCallbacks on components, and I could not figure out how to reimplement this cleanly using just those hooks exposed via the options object and __hooks prop.

I'm not sure if i have give you more hints on how to approach this issue, I have only scratched the surface myself. If you have questions, contact me in inferno's Slack, I'll be glad to guide you and help where I can.

[marvinhagemeister]

Disclaimer: I'm one of the maintainers of Preact.

They also have this stinky bit, this is where I personally got stuck: https://github.com/preactjs/preact/blob/master/hooks/src/index.js#L47-L61

The "stinky" bit you're referring to is the place where we invoke and process all pending effects that have been scheduled by various hooks. In our case component._renderCallbacks contains not just effects for hooks, but also callbacks for class lifecycle methods like componentDidMount.

You may be wondering why we mix those and the reason is simply to save some bytes. And yes, this allows hooks to be used in class components! We don't really advertise that though :+1:

[stylemistake]

And yes, this allows hooks to be used in class components!

Epic!

[stylemistake]

@marvinhagemeister to be clear, I don't think that code is bad in context of Preact, it's just written in a way that makes it less portable, at least that's how it appears. Maybe you may have a suggestion how to unwrap that functionality, or point out some specifics which may be useful to @BaibhaVatsa.

[marvinhagemeister]

Yeah, the code was specifically written for Preact and we never intended it to be used with other frameworks. I doubt that we'll change that as it would likely result in negative effects on our byte count. Some of us are experimenting with bringing hooks into the core itself, thus making it likely even less portable.

You're best bet is probably to copy that code and replace the integration to what's best for inferno. Our test suite should be pretty portable as we only assert against the rendered DOM.

[chrisdavies]

I built something similar to hooks for a standalone library I built recently. It was pretty handy, so I decided to bundle up the hooks functionality into its own library xferno. It's not quite React hooks, as it requires you to wrap your components in an xferno function call:

import { xferno, useState } from 'xferno';

const Counter = xferno(() => {
  const [count, setCount] = useState(0);

  return (
    <button onClick={() => setCount(count + 1)}>{count}</button>
  );
});

[chrisdavies]

OK. I published 0.0.3 of xferno. It now works almost identically to React hooks. You no longer need to wrap your functional components in an xferno call:

import { useState } from 'xferno';

function Counter() {
  const [count, setCount] = useState(0);

  return (
    <button onClick={() => setCount(count + 1)}>{count}</button>
  );
}

It's got some hackery going on under the hood, but if anyone on the core team likes it enough, I'd be down with renaming it to inferno-hooks or whatever. I didn't want to grab that name without permission.

[stylemistake]

One thing that I'm concerned about, is performance, because you essentially wrap every functional component with another component, regardless of whether the hooks are being used. If you ever get to the point of improving performance, you may want to expose inferno internals through the options object, for low-level access to the renderer. I might do some tests soon on /tg/station to measure the performance impact.

I am very excited!

[chrisdavies]

I have the same concern. I put together two (very simple) perf files perf-raw.jsx and perf-hooks.jsx, which I manually use for testing perf between the hooks implementation and the equivalent non-hook implemenation. So far, the performance is equivalent. But I'd definitely appreciate better / more real-world performance measurements.

[stylemistake]

@chrisdavies I did some A/B tests on /tg/station (which uses IE11 to render UIs), one with just inferno, and one with xferno. Identical code, no hooks, just to measure what amount of overhead xferno was generating during re-renders.

Screenshot of the interface I was testing. It uses a lot of simple html tags with known structure, inferno is known to optimize that very well, plus a pair of SVG curves.

• Before xferno: 6ms average (sample size: 76)
• After xferno: 29.5ms average (sample size: 82)

That's a pretty considerable slowdown.

Screenshot of another interface. In this UI, only high level components were used (such as <Box /> instead of <div>, <Button /> instead of <button />, and so forth).

Xferno was only marginally slower, by around 0.5ms, which is insignificant.

So, perhaps this may give you an idea where this slowdown originates from, even though this is only a surface level test.

[simonjoom]

if @Havunen could have a look on xferno will be great to create inferno-hooks in optimal way.. . https://github.com/infernojs/inferno/issues/1453#issuecomment-468157176

I really want to try hook in my next application, as all code seems to work with hooks now.. (Apollo ..Etc) which it seems to give much better coding practice.

[Jarred-Sumner]

I wonder if one could implement hooks with good performance via compiling functional components that use hooks into class components at runtime on the first usage. Since all hooks need to run each render, you have guarantees that even for nested hooks, it should be possible to track all the calls. If you can compile the dynamically created functions into functions on a prototype that aren't re-created each call, it should be faster than React Hooks.

Example:

const TextBox = ({text}) => {
  const isDirty = Inferno.useRef(false);

  const markDirty = Inferno.useCallback(() => {isDirty.current = true;}, [isDirty]);
  return <textarea onChange={markDirty} value={text} />
}

This would compile into something like:

class TextBox extends Inferno.Component {
   constructor(props) {
     super(props);

     this.$$ref0 = Inferno.createRef(false);
     this._childProps = {onChange: this.$$cb0, value: this.props.text};
   }

   $$cb0() {
     this.$$ref0.current = true;
   }

   render() {
     this._childProps.text = this.props.text;
     this._childProps.$$cb0 = this.$$cb0;
     return createElement(textarea, this._childProps);
   }
}

Probably the hardest part of this approach is correctly associating variable names with hook usages, without bloating the bundle with something like acorn

[stylemistake]

The real slowdown in xferno is not caused by the overhead of hooks, but by some small bug that negates child/type flags optimization on vnodes, which should be easy to fix.

[simonjoom]

Well lets start to fix that and create a real inferno-hooks.. if one moderator can have a look... Unfortunately my qualification not good enough to do that ;)

[ScottAwesome]

@stylemistake do you know where that issue is, by approximation?

I'm interested in designing hooks for inferno, but I'm not quite sure where this bug maybe

[stylemistake]

@ScottAwesome I have forgot already, but this is probably the piece that creates the slowdown:

https://github.com/chrisdavies/xferno/blob/master/src/xferno.jsx#L217-L223

VNodeFlags are being forced to ComponentUnknown, because well, the target component is abstracted away by the HookComponent and Inferno is required to go through all possible code paths.

VNodeFlags are normally calculated at compilation time by the babel-inferno-plugin, because it knows the structure of all nodes, and it tries to bake this information into createVNode calls.

HookComponent itself is not that thick, but it might contribute just a little bit, because it is still a wrapper.

[ScottAwesome]

@ScottAwesome I have forgot already, but this is probably the piece that creates the slowdown:

https://github.com/chrisdavies/xferno/blob/master/src/xferno.jsx#L217-L223

VNodeFlags are being forced to ComponentUnknown, because well, the target component is abstracted away by the HookComponent and Inferno is required to go through all possible code paths.

VNodeFlags are normally calculated at compilation time by the babel-inferno-plugin, because it knows the structure of all nodes, and it tries to bake this information into createVNode calls.

HookComponent itself is not that thick, but it might contribute just a little bit, because it is still a wrapper.

Thanks for the information, @stylemistake !

So, this is something that really should be optimized in core rather than as an addon library I imagine?

Would that be something that would be acceptable?

I wonder how hard it would be to simply extract some of the lifecycle method logic (since you can use it on function components too) and expose that as hooks in that case. I'd like to do something work with that if we can reach some basic clarification on how we would want that to look, so hooks can be baked into inferno directly

[stylemistake]

So, this is something that really should be optimized in core rather than as an addon library I imagine? Would that be something that would be acceptable?

I assume that both ways are fairly complex. In case of xferno, a lot of work has already been done, but figuring out how to optimize it might be hard. But if you choose to reimplement everything in core, you will spend more time, but might end up with a better implementation.

I have no preference one way or the other.

I wonder how hard it would be to simply extract some of the lifecycle method logic (since you can use it on function components too) and expose that as hooks in that case.

Here is what I think is the most optimal way of implementing hooks:

• You need to expose more of the internal lifecycle in the options object.
• Figure out how to store state in relation to vnodes. You could store it preact-style, or maintain it externally, one of the maints should help you with deciding on that, you can join Discord and ask them.
• The rest is implemented on top of that easily and modularly.

Check https://github.com/stylemistake/tgstation/commit/d1b13851c3131ea5c35db79e93d84b7b8ac6f647. I didn't do much in my branch, but I did expose various internal hook points, which might be of interest.

[simonjoom]

@chrisdavies I did some A/B tests on /tg/station (which uses IE11 to render UIs), one with just inferno, and one with xferno. Identical code, no hooks, just to measure what amount of overhead xferno was generating during re-renders.

Screenshot of the interface I was testing. It uses a lot of simple html tags with known structure, inferno is known to optimize that very well, plus a pair of SVG curves.

• Before xferno: 6ms average (sample size: 76)
• After xferno: 29.5ms average (sample size: 82)

That's a pretty considerable slowdown.

Screenshot of another interface. In this UI, only high level components were used (such as <Box /> instead of <div>, <Button /> instead of <button />, and so forth).

Xferno was only marginally slower, by around 0.5ms, which is insignificant.

So, perhaps this may give you an idea where this slowdown originates from, even though this is only a surface level test.

Hey bro

looking today at the actual code of xferno its seems that need some change Some code is not looking right for me first with let shouldUpdate = true; shouldUpdate is always true : shouldUpdate = shouldUpdate || !eq(hook.value, value); in this code !eq(hook.value, value) will be never called

https://github.com/chrisdavies/xferno/blob/82ff13782d96ebd5a9898bdf57ac3307c1e9b5ee/src/xferno.jsx#L106

This wrapper ask to update every component by default even if no-one hook change the state (shouldUpdate is by default true) https://github.com/chrisdavies/xferno/blob/82ff13782d96ebd5a9898bdf57ac3307c1e9b5ee/src/xferno.jsx#L186-L189 So it s certainly why it s much slower,, for opt the correct code should to compare and return the diff of any props and state

something like if (!this.tracker) { return (!eq(this.props, nextProps)||!eq(this.state, nextState)) }

there is some issue in the code i think here https://github.com/chrisdavies/xferno/blob/82ff13782d96ebd5a9898bdf57ac3307c1e9b5ee/src/xferno.jsx#L112

shouldUpdate from hook is never checked here for the rerender, only props

then why not change

     const renderResult = renderChild(component, nextProps, context);

      if (shouldUpdate) {
        tracker.renderResult = renderResult;
      }

to

      if (shouldUpdate) {
        tracker.renderResult = renderChild(component, nextProps, context);;
      }

else the renderchild will be called anyway twice so twice more render..

also with new inferno docs https://github.com/infernojs/inferno/commit/5a5ff08c597b552beb66cfd1edd99664e6243a57 indicate the possible use of some flags like HasVNodeChildren to avoid some normalisation.. ? maybe possible to do some opt in xferno

I m not good enough in benchmarking to recreate that, if @chrisdavies could make these changes and check the new benchmark will be nice... and with the new inferno 8.0 maybe? It s seems to have some improvement now, looking in the actual code ComponentUnknown don t give overload code for inferno now.. in core https://github.com/infernojs/inferno/blob/544bacde64b5efaf15d068b7404371def87faf2c/packages/inferno/src/core/implementation.ts#L90-L97

it s resolved directly to VNodeFlags. ComponentClass

Thks

[simonjoom]

Havunen Hey Hayunen Also the drawback of xferno hook implementation do not provide the async version of react useeffect who avoid to block browser painting.. Do inferno componentdidMount componentdidupdate version do run synchronously after rendering like react?

[simonjoom]

ok i did some work done on xferno. > > @ScottAwesome , @stylemistake , @chrisdavies

for me now xferno hooks work with my gatsby application after changing a bit the code source of xferno The application work with fast-refresh-overlay from gatsby ,... as it s not a small library and the result seems stable for me that sound a good indicator that the code work.

the code of fast-refresh-overlay use usememo, useref, usestate, useReducer, tested and the error portal finally well display smooth with the useLayouteffect :) (the code of gatsby fast-refresh is here)'

useLayouteffect code was mostly taken from preact

Usestate is rewritted to work with usereducer

i did add some tests when a dom element is destroyed that did produced some problem and infinite loop with usestate. I did a check for the existence of a parent for that with !component.$LI

I personaly use the code in development because gatsby use these hooks in his core now, but in production i don t use hooks so i won t use xferno for production (certainly bit slower because the component hook wrapper)

for those interested my xferno version in the branch here https://github.com/simonjoom/xferno

feel free to ask how to install it with inferno (i use source code and resource aliases in webpack)

xferno forked working well and tested with inferno7 in a webpack-dev-middleware SSR environnement, and my gatsby seems to compile faster now than with react

TODO I think that to optimise the hook hack, will be very nice to ask babel-plugin-inferno to detect component using hook and add a special flag on it to help only wrap those component in xferno and not all functionalcomponent

babel-plugin-inferno is used too

[farooqkz]

Would this "xferno" get merged into upstream? And what would be its effect on performance?

ping @Havunen @simonjoom

[XLearner]

Any updates? I want to refactor my project using Inferno, but I found that there is no useState hook in FunctionComponent. Or have another solution to solve it besides using ClassComponent?

[farooqkz]

Any updates? I want to refactor my project using Inferno, but I found that there is no useState hook in FunctionComponent. Or have another solution to solve it besides using ClassComponent?

Inferno is already very useful in projects which require high performance but a rewrite is really costly timewise.

[Havunen]

Ultimately the useState hook api is state management API. You could use any other state management with inferno to store information

[simonjoom]

Using xferno is not good for production it slowing down inferno. To be used only on library code using effects for some development status

Far those interested by my fork i just did update the readme to clarify a bit the installation. You need to scroll a bit in the code to understand how it s plugged.

[simonjoom]

Ultimately the useState hook api is state management API. You could use any other state management with inferno to store information

well the react hooks are done by react and used by many library.. not really nice to reinvent the wheel all the time.

[simonjoom]

Any updates? I want to refactor my project using Inferno, but I found that there is no useState hook in FunctionComponent. Or have another solution to solve it besides using ClassComponent?

Usestate do work with my fork this below for a bit of explanation for the installation of xferno in your react with webpack https://github.com/simonjoom/xferno/commit/37a216f76646b2dccc3659b18c4fb7c0ce3e1d8e#commitcomment-111208520

[einar-hjortdal]

well the react hooks are done by react and used by many library.. not really nice to reinvent the wheel all the time.

Inferno is not React, hooks are React-specific API. Inferno has its own API which is similar to the API React uses but not the same. No other library uses React hooks, because they are part of React. Inferno's API is most similar to an older version of React's API, Inferno does not promise to be React-compatible, but React-like.

If you really can't live without React hooks just use React or Preact instead. Preact promises React compatibility. I would recommend you try to do without React hooks.