search

infernojs / inferno

:fire: An extremely fast, React-like JavaScript library for building modern user interfaces
https://infernojs.org
MIT License
16.07k stars 634 forks source link

Using slatejs with inferno, not quite finishing render #859

Closed RB-bro closed 7 years ago

RB-bro commented 7 years ago

I set up a barebones repo here https://github.com/RB-bro/inferno-slate-compat I'm trying to start with the simple demo from the Slate.js page using Inferno instead of React for rendering. My barebones repo works fine with React, but does not render with inferno-compat.

I've turned on

localStore.debug = 'slate:*'

and discovered that the logs match up between React and inferno up until the the leaf render debug message. It appears in the React version, but not the Inferno one.

Everything behaves the way it does when using react to render, including updating the dom, as you can see similar html generated in the page (minus the editor), but it seems as if the leaf constructor is never invoked.

I've stepped through a lot of the Slate code in the Chrome DevTools, but have not been able to isolate the problem as no actual errors are being thrown. How should I proceed to find the problem so I can make a patch?

Thanks A lot.

Running Ubuntu 16.10 Chrome

Havunen commented 7 years ago

@RB-bro Hey can you test with latest Inferno 1.3.0-RC9 to see If that resolves this issue?

RB-bro commented 7 years ago

That fixed it!