search

infi-nl / the-infi-way

How we like to build software
https://way.infi.nl
Other
9 stars 8 forks source link

Translate core to english #44

Closed jeroenheijmans closed 2 years ago

jeroenheijmans commented 2 years ago

Fixes #39

LucaScorpion commented 2 years ago

I did a quick pass over this, and made a commit with some small fixes and improvements. Figured that'd be faster than pointing everything out, so I hope you don't mind ;)

If that looks okay to you, feel free to merge it!

LucaScorpion commented 2 years ago

Actually, one more thing pops to mind: the index.html. Currently that's in Dutch, should the landing page also become the English version now?

If so, in build.js we need to change the line:

const langMappings = { nl: 'index' };

to:

const langMappings = { en: 'index' };

and update the language links in the footer of the template file.

jeroenheijmans commented 2 years ago

Sounds good! Will add that last tweak and merge 👍🏻