infi-nl / the-infi-way

How we like to build software
https://way.infi.nl
Other
9 stars 8 forks source link

Improve expand/collapse feature #80

Closed drikusroor closed 1 year ago

drikusroor commented 1 year ago

This PR aims to:

Resolves #73

netlify[bot] commented 1 year ago

Deploy Preview for the-infi-way ready!

Name Link
Latest commit dddb82d52af702a3adc15b6d4e86ec40d17037c4
Latest deploy log https://app.netlify.com/sites/the-infi-way/deploys/64dc8904128e890008bfedb0
Deploy Preview https://deploy-preview-80--the-infi-way.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jeroenheijmans commented 1 year ago

Initial glance at the Deploy Preview: this is exactly what we were looking for IMO! Nice work 👍🏻

I have some small suggestions in mind still (but nothing huge) feature wise, will sit down a bit later to write them down. I see you also asked @LucaScorpion for a review so I'll rely for him to provide the code review (in addition to any feature changes he might suggest).

LucaScorpion commented 1 year ago

Overall some great improvements! Just some small questions/considerations in terms of code. I do have one slightly bigger concern about the expand/collapse button content, but we could also consider this good enough for now and address that later.