search

infincia / bip39-rs

A Rust implementation of BIP-0039
Apache License 2.0
54 stars 61 forks source link

Some spanish mnemonics isn't valid when they should be #26

Open mrbianchi opened 4 years ago

wigy-opensource-developer commented 4 years ago

Hi @mrbianchi! Does the latest https://github.com/maciejhirsz/tiny-bip39 also miss your expected results? There is an unfixed issue #21 on this codebase.

mrbianchi commented 4 years ago

Yes it fails too

El vie., 14 de febrero de 2020 5:26 a. m., wigy notifications@github.com escribió:

Hi @mrbianchi https://github.com/mrbianchi! Does the latest https://github.com/maciejhirsz/tiny-bip39 also fails your expected results? There is an unfixed issue #21 https://github.com/infincia/bip39-rs/issues/21 on this codebase.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/infincia/bip39-rs/issues/26?email_source=notifications&email_token=AGCY6ROAYDTJSLHOVMKVCKTRCZITHA5CNFSM4KUZOEW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELX7GVY#issuecomment-586150743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCY6RMI5GBZQ27JEBUSJ53RCZITHANCNFSM4KUZOEWQ .

wigy-opensource-developer commented 4 years ago

Without sharing your valuable master secrets, could you please provide here a sample Spanish mnemonic, your expected seed and what you actually got?

mrbianchi commented 4 years ago

mnemonic: camello pomelo toque oponer urgente lástima merengue cutis tirón pudor pomo barco expected seed: 062c9762ba2032ea10618f4c7c86dafd4f11aaaebf83690f9d81c89de897ecc21fef228ba44d5288de2386cffaeb1443ec528b4e838554b7cde4eedb0ce90f91

testing with Mnemonic::validate() it returns false when should return true