Identify parts of the code where implementing standard traits would make sense

[steveatinfincia]

Things like AsRef, Into, From, etc.

AsRef<str> and AsRef<[u8]> are implemented in a few spots now, in ways that are hopefully unsurprising and where the semantic meaning is obvious. There may be others that would be useful without making the crate unnecessarily complicated to use.

Semi-related to #4

• [x] AsRef<str>
  • [x] Mnemonic
  • Access to the phrase string value
  • [ ] MnemonicType
  • [x] Seed
  • Access to the hex string value
  • [ ] Language
• [x] AsRef<[u8]>
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [x] Seed
  • Access to the inner bytes as a slice
  • [ ] Language
• [x] Debug
  • [x] Mnemonic
  • [x] MnemonicType
  • [x] Seed
  • [x] Language
• [ ] Copy
  • [ ] Mnemonic
  • [x] MnemonicType
  • [ ] Seed
  • [x] Language
• [x] Clone
  • [x] Mnemonic
  • [x] MnemonicType
  • [x] Seed
  • [x] Language
• [ ] Default
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] From<&str>
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] From<&[u8]>
  • [ ] Mnemonic
  • Might make sense to create a Mnemonic from externally created/stored entropy
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] Eq
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] PartialEq
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] Ord
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] PartialOrd
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] Hash
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language
• [ ] Display
  • [ ] Mnemonic
  • [ ] MnemonicType
  • [ ] Seed
  • [ ] Language

[lsaether]

Hey thanks for building this! I was really surprised (but pleasantly surprised!) when I got a hit for my search of "bip39" on crates.io. I'm currently working on building an Ethereum light wallet / signing client and this will help greatly.

If I have time I'll definitely contribute back by implementing some of these standard traits.

[steveatinfincia]

Hi @lsaether, I'm glad you find the crate useful!

If you run in to any problems using it, or if there is anything you would like to see added or changed, please let me know and I will gladly help :)