Open gschmutz opened 5 days ago
Waiting for that good PR... Appreciate it.
Just submitted the PR. Also changed the documentation accordingly. I decided to name the template file service_conf.yaml.template
to distinguish it from the service_conf.yaml
file, which is generated and used at runtime.
And I was only able to change the EN version of the documentation ;-)
@KevinHuSh by the way, the reason why I needed this feature, is the fact that I want to add RAGFlow to the Platys Modern Data Platform stack, a flexible way to generate docker-compose.yml
files with various combinations of components (soon including RAGFlow).
@gschmutz ragflow
uses one of elasticsearch
and infinity
as the chunk store. It chould be an issue for Platys to select one.
@gschmutz
ragflow
uses one ofelasticsearch
andinfinity
as the chunk store. It chould be an issue for Platys to select one.
Hi @yuzhichang just saw the changes in the docker-compose-base.yaml
, will integrate it into Platys, thanks for letting me know. Also wasn't aware of Infinity.
Is there an existing issue for the same feature request?
Is your feature request related to a problem?
Manually editing the
service_conf.yaml
file and keeping it in sync with the.env
file could be avoided by dynamically replacing the values by the environment variables.Describe the feature you'd like
Instead of manually having to edit the
service_conf.yaml
file and mapping it into the docker container at runtime, a template file could be used and the values replaced by the environment variables from the.env
file.This template file needs to be copied into the docker image so that it is available for the replacement.
The replacement of the env vars would be done in the
entrypoint.sh
file and the mapping of theservice_conf.yaml
file in thedocker-compose.yaml
is no longer necessary.Describe implementation you've considered
see description above.
I have it working locally and could submit a pull request with the changes.
Documentation, adoption, use case
No response
Additional information
No response