infinisil / nixus

Experimental deployment tool supporting multi-host abstractions
GNU General Public License v3.0
200 stars 15 forks source link

Kill all backgrounded process groups instead of querying for session IDs #21

Closed antifuchs closed 4 years ago

antifuchs commented 4 years ago

Fixes #20: Session IDs aren't really working under Darwin, so let's find the PIDs of background processes via jobs and kill their whole process group.

With this fix in place, I can run the nixus build result under Darwin & deploy to my machine without receiving an error message at the end.

infinisil commented 4 years ago

The whole cancel logic never worked properly anyways (see also #5). In the future the deployment process should be a single Haskell binary that does everything, so no more bash shenanigans. For now I guess this is fine to just not fail on Darwin.