search

infinispan / infinispan-helm-charts

Apache License 2.0
13 stars 26 forks source link

Allow ServiceMonitor creation to be disabled #43

Closed ryanemerson closed 2 years ago

ryanemerson commented 2 years ago

Currently a ServiceMonitor is created if the k8s cluster supports the type, however in some cases this is not desirable as the resource may not be desired or the chart deployer may not have the required permissions to create such a resource.

We should allow users to disable ServiceMonitor creation via the values.yaml.

We can add the deploy.monitoring object, with a sub-field enabled to determine if the monitoring resources should be created or not. Monitoring should be enabled by default to provide backwards-compatibility.:

deploy:
  ...
  monitoring:
    enabled: true
nicknas commented 2 years ago

I could do this feature if there's an approval