search

infinispan / infinispan-helm-charts

Apache License 2.0
14 stars 29 forks source link

Patch to support networking.k8s.io/v1 Ingresses on 0.1.x versions of the Chart / ISPN 12.1.x. Bind to 0.0.0.0 #52

Closed jgchristian closed 2 years ago

jgchristian commented 2 years ago

Similar to #19, needed to support the new K8S Ingress types, but with the older version of ISPN (12.1.x)

Followed similar fix to #19 but made it conditional based on existence of API types.

Also now bind to 0.0.0.0 as per k8s convention (and also set as such in 0.2.x versions of the chart)

ryanemerson commented 2 years ago

Thanks for the PR @jgchristian and sorry about the slow reply.

Unfortunately the 0.1.x branch is no longer maintained, so we can't accept contributions as there's no plans for a future release.

On the main and 0.2.x branch we only support Kubernetes and Openshift versions greater than 1.21 and 4.8 respectively, so there's no need to check for the v1beta Ingress as all supported versions contain v1.

I appreciate that it's not clear that these are our supported Kubernetes versions, so I have created #54 to address this.

jgchristian commented 2 years ago

Ok... will stick to my forked build for now.