search

infinite-networks / InfiniteFormBundle

A collection of useful form types and extensions for Symfony.
169 stars 40 forks source link

Add configureOptions method to form types for SF 2.7 #28

Closed King2500 closed 9 years ago

King2500 commented 9 years ago

These changes remove the deprecation warnings for SF 2.7+

Solution is same as in other bundles (like FOSUserBundle), where both configureOptions and setDefaultOptions methods are provided.

merk commented 9 years ago

Could you please look into the failing test cases? Otherwise looks good to me.

King2500 commented 9 years ago

I think the latest fail is not my fault. What went wrong here?

 [Composer\Downloader\TransportException]                                     
  The "https://getcomposer.org/version" file could not be downloaded: Failed   
  to enable crypto                                                             
  failed to open stream: operation failed
merk commented 9 years ago

Something to do with travis timing out I suspect.

Thanks for working on this

King2500 commented 9 years ago

I did it like in FOSUserBundle: https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/Form/Type/GroupFormType.php

King2500 commented 9 years ago

@stof Thanks for pointing this out. Deprecation warnings are still there. I'll try to fix them too. :)