search

infinite-networks / InfiniteFormBundle

A collection of useful form types and extensions for Symfony.
169 stars 40 forks source link

Fix setDefaultOptions method in form types for SF 2.6+ forward compatibility #29

Closed King2500 closed 9 years ago

King2500 commented 9 years ago

We still had deprecations for setAllowedTypes and setNormalizers (since SF 2.6), because setDefaultOptions still gets called.

So I removed the internalConfigureOptions and did the version switching inside configureOptions via version_compare.

This issue got noted in https://github.com/infinite-networks/InfiniteFormBundle/pull/28#discussion_r32807377. Thanks @stof.

King2500 commented 9 years ago

Can you review this? @merk @stof

King2500 commented 9 years ago

Thanks for the note @stof .

Changed it now.

stof commented 9 years ago

:+1:

@merk please merge this to avoid deprecation warnings

merk commented 9 years ago

Thanks!