search

infinite-networks / InfiniteFormBundle

A collection of useful form types and extensions for Symfony.
169 stars 40 forks source link

Fix the check for strict deprecations #35

Closed stof closed 9 years ago

stof commented 9 years ago

Deprecations should be checked in a strict way for most builds, and be weak only for deps=low. Otherwise, the testsuite is not catching mistakes like the one fixed in #29.

note that the testsuite is failing for now with this change. this is perfectly expected as your bundle is currently not compatible with 2.7 without deprecations (contrary to what the changelog is saying) and the testsuite should catch it.

merk commented 9 years ago

We're still not on 2.7 for any projects using this bundle. I'll merge this PR and fix up any deprecation warnings that I can over the next few days.

Cheers!

stof commented 9 years ago

I'm in the process of migrating to 2.7, so I will contribute some fixes

merk commented 9 years ago

Thanks @stof!